Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic #91

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix panic #91

merged 1 commit into from
Nov 21, 2024

Conversation

eccles
Copy link
Member

@eccles eccles commented Nov 20, 2024 •
edited
Loading

When shutting down a receiver a panic ensues because the waitGroup index becomes less than zero

Some miscellaneous spelling errors fixed.

Found during development of another feature. Fix was tested during feature development.

AB#9875

@eccles eccles force-pushed the dev/paul/9875-fix-panic-when-shutting-down-receiver branch from aedc0e8 to 6181c84 Compare November 20, 2024 17:48
@eccles eccles force-pushed the dev/paul/9875-fix-panic-when-shutting-down-receiver branch 2 times, most recently from 54d7f71 to 38e0cf6 Compare November 21, 2024 08:43
@eccles
Fix panic
aaa3e84 
When shutting down a receiver a panic ensues because the waitGroup
index becomes less than zero

Some miscellaneous spelling errors fixed.

Found during development of anothet feature. Fix was tested during
feature development.

AB#9875
@eccles eccles force-pushed the dev/paul/9875-fix-panic-when-shutting-down-receiver branch from 38e0cf6 to aaa3e84 Compare November 21, 2024 09:01
landintrees
landintrees approved these changes Nov 21, 2024
View reviewed changes
Copy link

@landintrees landintrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul explained this and sounds correct to me

@eccles eccles merged commit 1f628f5 into main Nov 21, 2024
2 checks passed
@eccles eccles deleted the dev/paul/9875-fix-panic-when-shutting-down-receiver branch November 21, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landintrees landintrees landintrees approved these changes

@waarg waarg Awaiting requested review from waarg

@wp0pw wp0pw Awaiting requested review from wp0pw

@honourfish honourfish Awaiting requested review from honourfish

@j-hartley j-hartley Awaiting requested review from j-hartley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eccles @landintrees